First pass at making the server multilingual #1296
Draft
+13,550
−61,110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…database - now just done with migrations (#1300)
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.1.3 to 7.1.9. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.1.9/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.1.9 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.1.9 to 7.1.11. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.1.11/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.1.11 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix duplicate format keys in initial schema and in existing databases
* add orphaned format ids migration * use while loop and collections * cleaner * rm tmp console commands
…mlt-server into Multilingual-Data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a low impact way of getting multilingual support into BMLT. It is the method with the smallest changes to the UI and backend, but I think we will want to keep the behavior even when there is time and energy to implement more expensive methods, eg, something like the UI used for formats.
The main idea is this: when assembling the meeting object, we look at the lang_enum field (previously ignored). If there is more than one entry for the same key, we chose the one that matches the language that the user selected during login. If there are no matches, we choose the one that matches the app.locale. If there are still no matches, we take whicheber one comes first. For the old API, we use the lang_enum specified in the query string. To this all works for crouton, bread, etc.
Similarly, when the user writes something to the DB, we use his selected language. Instead of erasing all the meeting_data before writing the new data, we erase only those entries whose language matches.
This means to translate, you need to log in using the target language. When you do a meeting search, you'll see everything in the original language. You can then overwrite fields as appropriate and then save.
I'm not sure this is a worse UI than the one for formats. It fits to having a translater that goes though a bunch of meetings, rather than expecting the person entering the meeting to be multilingual.