New format schema #1405
Draft
New format schema #1405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The remaining tests seem to be connected with aggregator, which I think you guys wanted to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still some work to do on tests: e.g. the ones generate formats directly in the DB need to be adjusted. But I thought you should maybe review in case something needs to be adjusted for aggregator. For instance, the pivot table doesn't have an ID column, it uses the meeting and format ID combined as the PK...I hope aggregator is OK with this...
The code to save changes doesn't really work yet: these are never shown in the UI, maybe it's better to remove the feature? Up to you...
This doesn't clean up the code as much as I hoped, because we never actually hydrate the relationship, we always return two tables, connected by PKs. And even if we didn't have the old API to force this, JSON probably forces it.