Skip to content

Conversation

@fcengman
Copy link
Collaborator

First draft of the sponsorship page. Currently using dummy data combined with sponsor data pulled from prismic.

@fcengman fcengman requested a review from bndnio as a code owner September 26, 2022 02:25
@bndnio
Copy link
Owner

bndnio commented Sep 26, 2022

Thanks for taking a first cut at this!

Spinning it up locally, I see elements that are unbounded & behave a bit weird like the following:

Screen Shot 2022-09-25 at 10 47 54 PM

Screen Shot 2022-09-25 at 10 49 48 PM

Are you looking for feedback yet, or still iterating?

A couple leads I'd suggest looking at are using the container css class that's available to all components (see in _base.scss). And maybe creating a "card" component to wrap up the contents for a sponsor like the following (we have spectre imported and available for use in the repo already :) )
Screen Shot 2022-09-25 at 10 52 22 PM

@fcengman
Copy link
Collaborator Author

fcengman commented Sep 27, 2022 via email

@bndnio
Copy link
Owner

bndnio commented Oct 1, 2022

Alrightly, got the page setup in prismic :) The query feels a little funny because it doesn't use the ... ON <slice name> syntax, but I think that's here works non-the-less.

Screen Shot 2022-10-01 at 3 36 42 PM

Query:

query MyQuery {
  prismicSponsorshipPage {
    data {
      body {
        id
        items {
          card_description {
            text
            type
          }
          card_title {
            text
            type
          }
          cta_link {
            link_type
          }
          cta_text {
            type
            text
          }
        }
        primary {
          anchor
          tier
          sponsors_card_list_title {
            text
            type
          }
          text {
            text
            type
          }
        }
        slice_type
      }
      subtitle {
        type
        text
      }
      title {
        text
        type
      }
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants