Skip to content

Conversation

@HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Nov 30, 2025

This implements the Error.prototype.stack property as specified in the TC39 Error Stacks proposal (https://tc39.es/proposal-error-stacks).

@github-actions
Copy link

github-actions bot commented Nov 30, 2025

Test262 conformance changes

Test result main count PR count difference
Total 52,598 52,598 0
Passed 49,421 49,422 +1
Ignored 2,134 2,134 0
Failed 1,043 1,042 -1
Panics 0 0 0
Conformance 93.96% 93.96% +0.00%
Fixed tests (1):
test/staging/sm/extensions/regress-645160.js (previously Failed)

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 68.46847% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.53%. Comparing base (6ddc2b4) to head (286ebec).
⚠️ Report is 634 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/builtins/error/mod.rs 44.18% 24 Missing ⚠️
core/engine/src/vm/shadow_stack.rs 80.85% 9 Missing ⚠️
core/engine/src/value/display.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4552      +/-   ##
==========================================
+ Coverage   47.24%   56.53%   +9.29%     
==========================================
  Files         476      547      +71     
  Lines       46892    60099   +13207     
==========================================
+ Hits        22154    33979   +11825     
- Misses      24738    26120    +1382     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HalidOdat HalidOdat force-pushed the feature/error-stack-property branch 2 times, most recently from 6e5752d to 301a7d8 Compare January 7, 2026 17:21
@HalidOdat HalidOdat force-pushed the feature/error-stack-property branch 2 times, most recently from fa9e71e to a932134 Compare January 25, 2026 17:06
This commit implements the Error.prototype.stack property as specified
in the TC39 Error Stacks proposal (https://tc39.es/proposal-error-stacks).
@HalidOdat HalidOdat force-pushed the feature/error-stack-property branch from a932134 to 286ebec Compare January 25, 2026 17:28
@HalidOdat HalidOdat marked this pull request as ready for review January 25, 2026 17:30
@HalidOdat HalidOdat requested a review from a team January 25, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant