Skip to content

Conversation

@jedel1043
Copy link
Member

Test test/intl402/DateTimeFormat/prototype/format/throws-value-non-finite.js was panicking when running the test suite in debug mode. This PR fixes the panic.

@jedel1043 jedel1043 added this to the v1.0.0 milestone Jan 23, 2026
@jedel1043 jedel1043 requested a review from a team January 23, 2026 19:33
@jedel1043 jedel1043 added bug Something isn't working Intl Changes related to the `Intl` implementation labels Jan 23, 2026
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 52,598 52,598 0
Passed 49,421 49,421 0
Ignored 2,134 2,134 0
Failed 1,043 1,043 0
Panics 0 0 0
Conformance 93.96% 93.96% 0.00%

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.54%. Comparing base (6ddc2b4) to head (370b239).
⚠️ Report is 633 commits behind head on main.

Files with missing lines Patch % Lines
...e/engine/src/builtins/intl/date_time_format/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4588      +/-   ##
==========================================
+ Coverage   47.24%   56.54%   +9.29%     
==========================================
  Files         476      547      +71     
  Lines       46892    60058   +13166     
==========================================
+ Hits        22154    33957   +11803     
- Misses      24738    26101    +1363     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jedel1043 jedel1043 enabled auto-merge January 23, 2026 19:46
@jedel1043 jedel1043 added this pull request to the merge queue Jan 23, 2026
Merged via the queue into boa-dev:main with commit dd59f16 Jan 23, 2026
18 checks passed
@jedel1043 jedel1043 deleted the fix-dtf-panic-test branch January 23, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Intl Changes related to the `Intl` implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants