Clear User.current after controller actions #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pean
approved these changes
Nov 14, 2018
pean
left a comment
pean
left a comment
There was a problem hiding this comment.
This is great, I've been adding workarounds in test suites for this that I really looking forward to removing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests suites might get flaky when
User.currentis not cleanup after testsIn the "normal" Rails request/response lifecycle it's not needed to clear
User.currentafter a request has been processed (since it will reset on each new request). However, in tests this not the case. If we have an integration/system test that setsUser.currentand then afterwards we run a non-controller test (e.g. a background job test etc) we get unexpected behavior.