Register controller services #3662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes service registration in extension controllers by properly populating services through the ServicesTrait base class. The changes refactor the ExtensionSubscriber to inject dependencies directly into ExtensionController instances and clean up the service initialization flow.
Key changes:
- Refactored constructor to use promoted readonly properties instead of storing services in an array
- Added logic to inject services directly into
ExtensionControllerinstances during the controller event - Fixed method names to match their actual event handlers (renamed
onKernelResponsetoonKernelControllerandonConsoleResponsetoonConsoleCommand)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bobvandevijver
force-pushed
the
register-controller-services
branch
from
4dbae3d to
e2ad8f0
Compare
tobias-93
approved these changes
Dec 30, 2025
This comment was marked as outdated.
This comment was marked as outdated.
bobvandevijver
force-pushed
the
register-controller-services
branch
3 times, most recently
from
8f28765 to
abb9491
Compare
bobvandevijver
force-pushed
the
register-controller-services
branch
from
abb9491 to
7858c6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension controller should use the
ExtensionControllerbase class, which uses theServicesTrait. However, those services were not populated correctly. This PR fixes that.