-
Notifications
You must be signed in to change notification settings - Fork 248
Initial implementation of find_non_centrality for non_central_f_distribution
#1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@dschmitz89 how does this first commit look in regards to #1338 (comment) |
find_non_centrality for non_central_f_distribution [skip ci]find_non_centrality for non_central_f_distribution
|
Thanks @JacobHass8 for looking into this so quickly. This is a good start. I am not a boost maintainer (barely a boost developer), so can only comment from a high level. The most important missing bit here is tests for the new functionality. I could not find the current noncentral F distribution tests after 2 minutes though, so we will have to rely on the boost devs to guide us a little here. |
|
Yup, tests needed. Non central F is treated as a special case of the non-central beta (which is where most of the tests are). Non-central F tests are fairly lightweight, just there to make sure we have the transformation to non-central beta correct really: https://github.com/boostorg/math/blob/develop/test/test_nc_f.cpp. A similar level of sanity checking would probably suffice for this function I would guess? |
I've added a couple of tests and documentation. The tests and documentation copy what is done for the |
|
@jzmaddock could I get a review on this when you get the chance? Are there any test cases that you can think of that I should add? |
See #1305 for for details.