-
Notifications
You must be signed in to change notification settings - Fork 96
Suppress warnings from dependency libraries #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
35416d8 to
130ae09
Compare
130ae09 to
bc7d680
Compare
bc7d680 to
f898602
Compare
|
@pdimov, I don't have merge access. please go ahead and merge this if it looks good to you. |
|
Why did you remove |
Ah, sorry. I couldn’t find anything in the commit message and guessed it might have been related to old bugs that should have been fixed by now. |
|
The problem is that test_xml_parser_rapidxml.cpp writes out xml files with fixed names, so when two instances of this test are run in parallel, they step on each other's toes. To remove -j1 the test needs to be fixed to not do that, e.g. by adding a random prefix to the file names, or by using a temporary directory with a random name. |
It might be as simple as adding random prefixes to the file names passed to this function: property_tree/test/test_utils.hpp Lines 108 to 116 in 5c5e2c9
I can test it, and if it doesn't work, we can settle for adding |
|
I already put back the -j1 to fix the CI failures, but we can in principle apply this fix, if it works. |
No description provided.