Skip to content

Conversation

@ashtum
Copy link
Collaborator

@ashtum ashtum commented Jun 9, 2025

No description provided.

@ashtum ashtum force-pushed the suppress-deps-warnings branch 2 times, most recently from 35416d8 to 130ae09 Compare June 9, 2025 12:51
@ashtum ashtum force-pushed the suppress-deps-warnings branch from 130ae09 to bc7d680 Compare June 9, 2025 15:06
@ashtum ashtum force-pushed the suppress-deps-warnings branch from bc7d680 to f898602 Compare June 9, 2025 15:27
@ashtum ashtum requested a review from pdimov June 9, 2025 15:40
@ashtum
Copy link
Collaborator Author

ashtum commented Jun 9, 2025

@pdimov, I don't have merge access. please go ahead and merge this if it looks good to you.

@pdimov pdimov merged commit 5c5e2c9 into boostorg:develop Jun 9, 2025
57 of 58 checks passed
@pdimov
Copy link
Member

pdimov commented Jun 30, 2025

Why did you remove -j1 from the b2 invocations in this PR? This leads to sporadic failures in test_xml_parser_rapidxml.

@ashtum
Copy link
Collaborator Author

ashtum commented Jun 30, 2025

Why did you remove -j1 from the b2 invocations in this PR? This leads to sporadic failures in test_xml_parser_rapidxml.

Ah, sorry. I couldn’t find anything in the commit message and guessed it might have been related to old bugs that should have been fixed by now.

@pdimov
Copy link
Member

pdimov commented Jun 30, 2025

The problem is that test_xml_parser_rapidxml.cpp writes out xml files with fixed names, so when two instances of this test are run in parallel, they step on each other's toes. To remove -j1 the test needs to be fixed to not do that, e.g. by adding a random prefix to the file names, or by using a temporary directory with a random name.

@ashtum
Copy link
Collaborator Author

ashtum commented Jun 30, 2025

The problem is that test_xml_parser_rapidxml.cpp writes out xml files with fixed names, so when two instances of this test are run in parallel, they step on each other's toes. To remove -j1 the test needs to be fixed to not do that, e.g. by adding a random prefix to the file names, or by using a temporary directory with a random name.

It might be as simple as adding random prefixes to the file names passed to this function:

// Create test files
test_file file_1(test_data_1, filename_1);
test_file file_2(test_data_2, filename_2);
test_file file_out("", filename_out);
rf(filename_1, pt); // Read file
wf(filename_out, pt); // Write file
Ptree pt2;
rf(filename_out, pt2); // Read file again

I can test it, and if it doesn't work, we can settle for adding -j1 because I doubt it's worth putting in more time, as we don't frequently make changes to this repository.

@pdimov
Copy link
Member

pdimov commented Jun 30, 2025

I already put back the -j1 to fix the CI failures, but we can in principle apply this fix, if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants