Skip to content

fix: make boost::rational<boost::safe_numerics::safe<uint64_t>> work #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yury-harmonic wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: make boost::rational<boost::safe_numerics::safe<uint64_t>> work #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdcbe51
fix: make `boost::rational<boost::safe_numerics::safe<uint64_t>>` work
yury-harmonic Aug 28, 2025
2837644
Try `BOOST_CONSTEXPR`
yury-harmonic Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 20 additions & 13 deletions include/boost/rational.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
// Nickolay Mladenov, for the implementation of operator+=

// Revision History
// 10 Aug 25 Don't use `-` on unsigned types (Yury Kudryashov)
// 12 Nov 20 Fix operators to work with C++20 rules (Glen Joseph Fernandes)
// 02 Sep 13 Remove unneeded forward declarations; tweak private helper
// function (Daryle Walker)
Expand Down Expand Up @@ -324,9 +325,11 @@ class rational
num /= gcd;
den *= i / gcd;

if(den < zero) {
num = -num;
den = -den;
if BOOST_CONSTEXPR (std::numeric_limits<IntType>::is_signed) {
if(den < zero) {
num = -num;
den = -den;
}
}

return *this;
Expand Down Expand Up @@ -604,9 +607,11 @@ BOOST_CXX14_CONSTEXPR rational<IntType>& rational<IntType>::operator/= (const ra
num = (num/gcd1) * (r_den/gcd2);
den = (den/gcd2) * (r_num/gcd1);

if (den < zero) {
num = -num;
den = -den;
if BOOST_CONSTEXPR (std::numeric_limits<IntType>::is_signed) {
if (den < zero) {
num = -num;
den = -den;
}
}
return *this;
}
Expand Down Expand Up @@ -902,14 +907,16 @@ BOOST_CXX14_CONSTEXPR void rational<IntType>::normalize()
num /= g;
den /= g;

if (std::numeric_limits<IntType>::is_bounded && den < -(std::numeric_limits<IntType>::max)()) {
BOOST_THROW_EXCEPTION(bad_rational("bad rational: non-zero singular denominator"));
}
if BOOST_CONSTEXPR (std::numeric_limits<IntType>::is_signed && std::numeric_limits<IntType>::is_bounded) {
if (den < -(std::numeric_limits<IntType>::max)()) {
BOOST_THROW_EXCEPTION(bad_rational("bad rational: non-zero singular denominator"));
}

// Ensure that the denominator is positive
if (den < zero) {
num = -num;
den = -den;
// Ensure that the denominator is positive
if (den < zero) {
num = -num;
den = -den;
}
}

BOOST_ASSERT( this->test_invariant() );
Expand Down