Skip to content

install: Add bootloader option #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgwalters merged 1 commit into from
Jan 27, 2026
Merged

install: Add bootloader option #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions crates/kit/src/install_options.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ pub struct InstallOptions {
/// Default to composefs-native storage
#[clap(long)]
pub composefs_backend: bool,

/// Which bootloader to use for composefs-native backend
#[clap(long, requires = "composefs_backend")]
Copy link
Collaborator

@cgwalters cgwalters Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we need to require this here, but it doesn't hurt.

pub bootloader: Option<String>,
}

impl InstallOptions {
Expand Down Expand Up @@ -70,6 +74,11 @@ impl InstallOptions {
args.push("--composefs-backend".to_owned());
}

if let Some(b) = &self.bootloader {
args.push("--bootloader".into());
args.push(b.clone());
}
Comment on lines +77 to +80
Copy link
Collaborator

@cgwalters cgwalters Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously fine as is but can also be args.extend(self.bootloader.map(|v| ["--bootloader", v).cloned()) probably


args
}
}