Skip to content

Conversation

@cgwalters
Copy link
Contributor

The default containers.conf includes net.ipv4.ping_group_range=0 0 which fails in nested containers because /proc/sys is read-only. This causes 'podman build' to fail with:

open /proc/sys/net/ipv4/ping_group_range: Read-only file system

This matches the approach used by the official quay.io/podman/stable image (containers/image_build) which sets default_sysctls = [] in its podman-containers.conf.

Assisted-by: OpenCode (claude-opus-4-5@20251101)

@cgwalters cgwalters enabled auto-merge (squash) January 30, 2026 19:39
@gemini-code-assist
Copy link

Summary of Changes

Hello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the development environment's support for running Podman within another container (podman-in-podman). It specifically addresses and resolves issues related to podman build failures caused by read-only /proc/sys in nested environments, ensuring a more robust and compatible nested container experience by dynamically configuring Podman settings.

Highlights

  • Nested Container Support: Improved the development environment's ability to run Podman within another container (podman-in-podman).
  • Fix for podman build failures: Resolved issues where podman build failed in nested containers due to a read-only /proc/sys when net.ipv4.ping_group_range was set.
  • Dynamic containers.conf Configuration: The userns-setup script now dynamically generates /etc/containers/containers.conf to explicitly set default_sysctls = [], preventing Read-only file system errors.
  • Alignment with Upstream: The configuration approach for nested containers now aligns with the official quay.io/podman/stable image.
  • Enhanced Documentation: Added a comprehensive 'Nested container support' section to README.md, detailing configuration differences and handling of constrained vs. full UID namespaces.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves nested container support by disabling default sysctls that cause issues in read-only /proc/sys environments, a problem that can prevent podman build from running. The changes are logical and well-documented in the updated README. My review includes one suggestion to refactor the configure_containers_conf function in devenv/userns-setup to reduce code duplication and improve maintainability.

The default containers.conf includes net.ipv4.ping_group_range=0 0 which
fails in nested containers because /proc/sys is read-only. This causes
'podman build' to fail with:

  open `/proc/sys/net/ipv4/ping_group_range`: Read-only file system

This matches the approach used by the official quay.io/podman/stable
image (containers/image_build) which sets default_sysctls = [] in its
podman-containers.conf.

Assisted-by: OpenCode (claude-opus-4-5@20251101)
Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters cgwalters merged commit 6db3325 into bootc-dev:main Jan 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants