Skip to content

Conversation

@florentfougeres
Copy link

Hello @borysiasty and thank you for your handy plugin.

I'd like to suggest an evolution: I'd like to create a temporary layer with just one click. So as not to overload the interface, I'm proposing this only for the three basic types: Point, Line and Polygon.

Video:

newtemporarylayer.mp4

ping @jmkerloch

…n geometry types (point, line, polygon) with a single click.
@florentfougeres
Copy link
Author

Hi @borysiasty, can you give me some feedback on this PR?

Thanks :)

@borysiasty
Copy link
Owner

Sorry for the late reply.

I'm actually not in favor of adding a new toolbar. We already have quite a few, making the QGIS window quite cluttered. The current plugin already reduces the number of clicks needed from four to two...

Instead of the new toolbar, what do you think about converting the existing button into a drop-down menu? That way, you'd still need one click for the most recently used geometry type, and two clicks (but side by side) to switch types. Plus, you can assign keyboard shortcuts for even faster access.

I'd also suggest refining the icons by combining the memory circuit symbol with the yellow “new” star and a geometry-specific shape. That would follow the existing GUI convention.

Another point of concern is keeping the add_layer method inside the dialog, making the dialog unnecessarily complex. Previously, the add_layer method was part of the dialog class because it was only used there. But now, as its use is broader, I’d definitely move it outside. The simplest solution might be to move it to the plugin class (and pass it to the dialog's init as a callback).

@jmkerloch do you have any thoughts?

@jmkerloch
Copy link
Contributor

@borysiasty for the add_layer method, I agree that this would be better to move it to a specific file. Maybe a new utils.py, this is a very generic name but I think it fits our needs.

I think the toolbar can be a good idea but this should be configurable. By default there should be no toolbar.

@florentfougeres this requires more work because we need to introduce a new dialog for plugin configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants