This repository was archived by the owner on Sep 16, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 68
Select the first track of an album will fill the playlist with that album #4
Open
pascalgeo
wants to merge
1,880
commits into
bradfitz:master
Choose a base branch
from
nikclayton:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
250 commits is too much to review. Also, development has moved elsewhere. This is no longer the home for the version on the Play store. |
for now, until we can upgrade to AndroidX and fix it properly
to try to avoid "Conext.startForegroundService did not then call Service.startForeground" exceptions
submitted by 2019 Olivier Sirol <czo@free.fr>
which is revealed in the french translation
also wait for the sticky PlayersChanged event to handle the case where no players are connected to ther server. fixes #645
to make sure all buttons are visible.
1 item, to workaround some issues in LMS where the page size is confused with the number of items available
Skip play actions with "playlist control load ..." with a null id. This can happen eg. when LMS returns an "Empty" item for a search without any matching results.
Possibility to undo a clear current playlist Remove a track by swiping left or right Touch and hold to move a track
We have seen crashes from using parent.getItemAtPosition(pos) in onItemSelected(AdapterView<?> parent, View view, int pos, long id) so lookup the name at the selected position in the adapter instead.
Apparently onFling can get a null e1 MotionEvent on some devices. OnFling is rewritten to use velocityX and velocityY (wich can't be null), to detect the direction of the swipe.
so it can handle cases where the type arguments of the base class are not mentioned in the type hierarchy up to the current class. This is the case for PlayerBaseView.
if drawable of currently playing item is not a BitmapDrawable.
the media store. To avoid Android mistakenly assume it's an mp3 file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of the Squeezebox Touch when browsing albums and selecting a track is to replace current playlist with the newly selected album. Currently Squeezer requests to first clear the playlist, which stops the music, and then select and add another album. Having an option that will replace current playing album with a whole new one would be nice.
More over, when scrolling through albums' list, it would be nice to highlight the album that contains the playing tracks, in the same way the currently played track is highlighted in the playlist.