Skip to content

Handle null resource more gracefully in toId #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brdv merged 1 commit into from
Jan 5, 2026
Merged

Handle null resource more gracefully in toId #34

brdv merged 1 commit into from
Jan 5, 2026

Conversation

@brdv
Copy link
Member

@brdv brdv commented Jan 5, 2026

Summary

Fixes a bug where passing null to a JsonApiResource would cause errors when trying to access properties during ID resolution.

Changes

  • Added null check in getId() to return null early when resource is null
  • Added test case to verify null resources return empty data arrays

@brdv brdv requested a review from mooya January 5, 2026 13:05
@brdv brdv self-assigned this Jan 5, 2026
mooya
mooya approved these changes Jan 5, 2026
View reviewed changes
Copy link

@mooya mooya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@brdv brdv merged commit ecdd43c into main Jan 5, 2026
2 checks passed
@brdv brdv deleted the fix/handle-null-resource branch January 5, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mooya mooya mooya approved these changes

Assignees

@brdv brdv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brdv @mooya