Add serde serialization to google generated types #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knjiang
force-pushed
the
01-25-fix_google_generated_types
branch
2 times, most recently
from
9b5554b to
1532447
Compare
knjiang
force-pushed
the
01-25-fix_google_generated_types
branch
from
1532447 to
feb3b52
Compare
knjiang
commented
Jan 25, 2026
Comment on lines
-9
to
+7
| use lingua::serde_json; | ||
| use big_serde_json as serde_json; |
Contributor
Author
There was a problem hiding this comment.
importing from big_serde_json instead of lingua to avoid cylical dep
Comment on lines
-24
to
-29
| /// Lightweight serde struct for Google GenerateContent request validation. | ||
| /// | ||
| /// This mirrors the structure of Google's protobuf GenerateContentRequest | ||
| /// but uses serde for JSON deserialization. | ||
| #[derive(Debug, Clone, Serialize, Deserialize)] | ||
| #[serde(rename_all = "camelCase")] |
Contributor
Author
There was a problem hiding this comment.
deleted types now that we use generated_pbjson.rs
knjiang
changed the title
ankrgyl
approved these changes
Jan 25, 2026
Contributor
ankrgyl
left a comment
ankrgyl
left a comment
There was a problem hiding this comment.
looks fine (although to be honest, i only looked at the two place you commented)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The google protobuf types are generated as prost structs which don't map to JSON directly.
This PR fixes google generated types by getting rid of the handwritten serde types in
detect.rsand using pbjson to generate serde impls.