Skip to content

Fix(BREV-2215): Shadeform | Could not find refID error | when manually created instance has no tags #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aditsharma55 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix(BREV-2215): Shadeform | Could not find refID error | when manually created instance has no tags #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9450d25
Fix(BREV-2215): missing refid for shadeform
aditsharma55 Dec 19, 2025
a764c9a
Fix(BREV-2215): added warning logs
aditsharma55 Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions v1/providers/shadeform/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,11 @@ func (c *ShadeformClient) ListInstances(ctx context.Context, _ v1.ListInstancesA
for _, instance := range resp.Instances {
singleInstance, err := c.convertShadeformInstanceToV1Instance(instance)
if err != nil {
return nil, errors.WrapAndTrace(err)
c.logger.Warn(ctx, "skipping instance without refID tag",
v1.LogField("instanceID", instance.Id),
v1.LogField("instanceName", instance.Name),
v1.LogField("error", err.Error()))
continue
Copy link
Contributor

@patelspratik patelspratik Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we would want an warn or err log line here so we can track these?

Copy link
Author

@aditsharma55 aditsharma55 Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, Prateek!
Added a warning log with instance ID, name, and error details to further track such instances.

}
instances = append(instances, *singleInstance)
}
Expand Down Expand Up @@ -357,13 +361,13 @@ func (c *ShadeformClient) convertShadeformInstanceToV1Instance(shadeformInstance

refID, found := tags[refIDTagName]
if !found {
return nil, errors.WrapAndTrace(errors.New("could not find refID tag"))
return nil, fmt.Errorf("instance missing refID tag: instanceID=%s, instanceName=%s", shadeformInstance.Id, shadeformInstance.Name)
}
delete(tags, refIDTagName)

cloudCredRefID, found := tags[cloudCredRefIDTagName]
if !found {
return nil, errors.WrapAndTrace(errors.New("could not find cloudCredRefID tag"))
return nil, fmt.Errorf("instance missing cloudCredRefID tag: instanceID=%s, instanceName=%s", shadeformInstance.Id, shadeformInstance.Name)
}
delete(tags, cloudCredRefIDTagName)

Expand Down
Loading