Double check heavy archive size before start downloading #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #601 +/- ##
==========================================
- Coverage 42.90% 42.81% -0.09%
==========================================
Files 278 278
Lines 51883 51924 +41
Branches 51883 51924 +41
==========================================
- Hits 22260 22233 -27
- Misses 28455 28528 +73
+ Partials 1168 1163 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pashinov
force-pushed
the
feat/check-archive-size
branch
2 times, most recently
from
7a3738e to
9bc1b25
Compare
pashinov
force-pushed
the
feat/check-archive-size
branch
2 times, most recently
from
7fff7ef to
7e67215
Compare
0xdeafbeef
approved these changes
Feb 20, 2025
core/src/blockchain_rpc/client.rs
Outdated
Comment on lines
563
to
568
| .choose_multiple(NEIGHBOUR_COUNT, NeighbourType::Reliable); | ||
|
|
||
| let mut futures = FuturesUnordered::new(); | ||
| for neighbour in neighbours { | ||
| futures.push(self.overlay_client().query_raw(neighbour, req.clone())); | ||
| } |
Member
There was a problem hiding this comment.
.map(self.overlay_client().query_raw(neighbour, req.clone())
.collect()
core/src/blockchain_rpc/client.rs
Outdated
| id, | ||
| size, | ||
| chunk_size, | ||
| } => match is_reliable_size(expected_size.get(), size.get()) { |
Member
There was a problem hiding this comment.
ArchiveInfo::Found {
id,
size,
chunk_size,
} is_reliable_size(expected_size.get(), size.get()) => ...
```
pashinov
force-pushed
the
feat/check-archive-size
branch
from
a5ea341 to
884e59e
Compare
pashinov
changed the title
0xdeafbeef
force-pushed
the
master
branch
6 times, most recently
from
5a83fcb to
1b9e10a
Compare
Rexagon
force-pushed
the
master
branch
4 times, most recently
from
dad89c9 to
8d9ab65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.