Skip to content

Conversation

@Mododo
Copy link
Member

@Mododo Mododo commented Sep 22, 2025

After node state was deleted, node should not apply latest key block on top of newer genesis from global config

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

None

BLOCKCHAIN CONFIGURATION MODEL CHANGES

None


COMPATIBILITY

Full

SPECIAL DEPLOYMENT ACTIONS

Not Required


PERFORMANCE IMPACT

No impact expected


TESTS

Unit Tests

No coverage

Network Tests

No coverage

Manual Tests

Stop the node, delete block state, apply new genesis, start the node

After node state was deleted, node should not apply latest key block on top of newer genesis from global config
@github-actions
Copy link

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=913

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=913
  • Run specific test: gh workflow run network-tests.yml -f pr_number=913 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.60%. Comparing base (0e7e859) to head (98d66f3).
⚠️ Report is 116 commits behind head on master.

Files with missing lines Patch % Lines
collator/src/mempool/impls/std_impl.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
- Coverage   46.65%   46.60%   -0.05%     
==========================================
  Files         330      330              
  Lines       59410    59418       +8     
  Branches    59410    59418       +8     
==========================================
- Hits        27716    27694      -22     
- Misses      30251    30287      +36     
+ Partials     1443     1437       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants