Skip to content

Conversation

@MrWad3r
Copy link
Member

@MrWad3r MrWad3r commented Dec 12, 2025

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

[None]

BLOCKCHAIN CONFIGURATION MODEL CHANGES

[None]


COMPATIBILITY

Fully compatible

Affected features:

  • [State]
  • [Persistent State]
  • [Queue. Diff]
  • [Collator]

Removed hardcoded checks for seqno == 0 in the collator and message queue logic. These checks were replaced with comparisons against zerostate_id.seqno, ensuring correct behavior when starting execution from a non-zero zerostate sequence number.

SPECIAL DEPLOYMENT ACTIONS

[Not Required]


PERFORMANCE IMPACT

[No impact expected]


TESTS

Unit Tests

[Covered by:]

Previous existing collator and queue tests

Network Tests

[No coverage]

Manual Tests

  1. Start a local network consisting of three validator nodes. Allow the network to run until multiple masterchain and shard blocks are produced.
  2. Stop the network. Using the new CLI command, generate zerostate files corresponding to a specified masterchain block.
  3. Decompress the generated zerostate files using zstd.
  4. Restart the network using the decompressed zerostate files as the initial state. The network must resume execution starting from the specified masterchain zerostate block.

Additionally, a Python virtual environment (venv) was used to set up tooling for token transfers from the giver account to a generic account. All transfer operations completed successfully, confirming correct network behavior.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=975

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=975
  • Run specific test: gh workflow run network-tests.yml -f pr_number=975 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@MrWad3r MrWad3r force-pushed the feature/hf branch 4 times, most recently from 6dca936 to 611069c Compare December 22, 2025 14:29
@broxus broxus deleted a comment from github-actions bot Dec 22, 2025
@broxus broxus deleted a comment from github-actions bot Dec 22, 2025
@broxus broxus deleted a comment from github-actions bot Dec 22, 2025
@broxus broxus deleted a comment from github-actions bot Dec 22, 2025
@MrWad3r MrWad3r force-pushed the feature/hf branch 2 times, most recently from 4bdaa7e to dc89fd5 Compare December 23, 2025 15:28
@MrWad3r MrWad3r marked this pull request as ready for review December 24, 2025 15:19
@MrWad3r MrWad3r changed the title Feature/hf Ability to create generic forked state and run network using prepared state Dec 24, 2025
@MrWad3r MrWad3r requested review from Rexagon and pashinov December 24, 2025 15:21
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 24.15254% with 537 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.06%. Comparing base (4e0f1cc) to head (baaec66).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cli/src/cmd/tools/hardfork.rs 0.00% 196 Missing ⚠️
core/src/block_strider/starter/cold_boot.rs 0.00% 125 Missing ⚠️
core/src/storage/node_state/mod.rs 24.56% 38 Missing and 5 partials ⚠️
...src/storage/persistent_state/shard_state/writer.rs 66.66% 16 Missing and 7 partials ⚠️
block-util/src/block/block_proof_stuff.rs 0.00% 15 Missing ⚠️
core/src/storage/shard_state/mod.rs 0.00% 15 Missing ⚠️
cli/src/node/mod.rs 0.00% 14 Missing ⚠️
core/src/storage/persistent_state/mod.rs 13.33% 13 Missing ⚠️
collator/src/manager/mod.rs 58.33% 10 Missing ⚠️
core/src/block_strider/provider/mod.rs 73.68% 7 Missing and 3 partials ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #975      +/-   ##
==========================================
- Coverage   46.30%   46.06%   -0.25%     
==========================================
  Files         357      361       +4     
  Lines       62235    63049     +814     
  Branches    62235    63049     +814     
==========================================
+ Hits        28820    29044     +224     
- Misses      31914    32482     +568     
- Partials     1501     1523      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

❌ CLI reference check failed in CI.

Please run just update_cli_reference, add the updated docs/cli-reference.md, and push the changes.

@MrWad3r MrWad3r force-pushed the feature/hf branch 3 times, most recently from f20aacb to fa23313 Compare December 26, 2025 10:19
@0xdeafbeef
Copy link
Member

for top_block_id in top_other_updated_shard_blocks_ids.iter() {
if top_block_id.seqno == 0 {
continue;
}

Should this be also checked?

@github-actions
Copy link

❌ CLI reference check failed in CI.

Please run just update_cli_reference, add the updated docs/cli-reference.md, and push the changes.

@github-actions
Copy link

❌ CLI reference check failed in CI.

Please run just update_cli_reference, add the updated docs/cli-reference.md, and push the changes.

@Rexagon Rexagon force-pushed the feature/hf branch 3 times, most recently from f39aac1 to b6f0947 Compare December 30, 2025 14:09
@Rexagon Rexagon mentioned this pull request Dec 30, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants