-
Notifications
You must be signed in to change notification settings - Fork 7
Ability to create generic forked state and run network using prepared state #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=975Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
6dca936 to
611069c
Compare
4bdaa7e to
dc89fd5
Compare
…tests. Add progress bar for saved state.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #975 +/- ##
==========================================
- Coverage 46.30% 46.06% -0.25%
==========================================
Files 357 361 +4
Lines 62235 63049 +814
Branches 62235 63049 +814
==========================================
+ Hits 28820 29044 +224
- Misses 31914 32482 +568
- Partials 1501 1523 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
❌ CLI reference check failed in CI. Please run |
f20aacb to
fa23313
Compare
|
tycho/collator/src/collator/do_collate/finalize.rs Lines 102 to 105 in 9680b4d
Should this be also checked? |
|
❌ CLI reference check failed in CI. Please run |
|
❌ CLI reference check failed in CI. Please run |
f39aac1 to
b6f0947
Compare
Pull Request Checklist
NODE CONFIGURATION MODEL CHANGES
[None]
BLOCKCHAIN CONFIGURATION MODEL CHANGES
[None]
COMPATIBILITY
Fully compatible
Affected features:
Removed hardcoded checks for seqno == 0 in the collator and message queue logic. These checks were replaced with comparisons against zerostate_id.seqno, ensuring correct behavior when starting execution from a non-zero zerostate sequence number.
SPECIAL DEPLOYMENT ACTIONS
[Not Required]
PERFORMANCE IMPACT
[No impact expected]
TESTS
Unit Tests
[Covered by:]
Previous existing collator and queue tests
Network Tests
[No coverage]
Manual Tests
Additionally, a Python virtual environment (venv) was used to set up tooling for token transfers from the giver account to a generic account. All transfer operations completed successfully, confirming correct network behavior.