feat(schemas): implement value-based equality for all schemas and constraints #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ints Add proper ==() and hashCode implementations to all AckSchema classes and Constraint classes. This enables schemas to work correctly as Map keys, in Sets, and fixes UniqueItemsConstraint for detecting duplicate objects. All schemas are @immutable but were using identity equality; now they use value-based equality matching their configuration. Includes comprehensive test coverage for equality semantics across all schema and constraint types.
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Collaborator
Author
|
Superseded by PR from properly named branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add proper
==()andhashCodeimplementations to allAckSchemaandConstraintclasses. Schemas were marked@immutablebut relied on identity equality, breaking their use as Map keys and in Sets. This also fixesUniqueItemsConstraint, which depends on value equality for detecting duplicate objects in lists.Changes
Testing
All 905 existing tests pass plus 62 new equality tests covering schemas as Map keys/Set members and
copyWith()preserving equality.