fix(schemas): add validation for child schemas in discriminated unions #66
+369
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Discriminated unions require child schemas to return Map types. This commit adds proper runtime validation with a helpful error message when a child schema returns a non-Map type (e.g., when using .transform<Cat>() on a child schema). The error message guides users to the correct pattern: apply .transform() to the discriminated union itself, not to individual child schemas. Changes: - Added runtime type check after child schema validation - Added helpful error message explaining the correct transform pattern - Added documentation with code example showing correct usage - Added test verifying the error message and correct pattern
leoafarias
force-pushed
the
claude/fix-discriminated-transforms-sHOui
branch
from
d59e81c to
1e4adb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discriminated unions require child schemas to return Map types. This commit
adds proper runtime validation with a helpful error message when a child
schema returns a non-Map type (e.g., when using .transform() on a
child schema).
The error message guides users to the correct pattern: apply .transform()
to the discriminated union itself, not to individual child schemas.
Changes: