feat: add applyVariants method for NamedVariant application #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds applyVariants() method to VariantStyleMixin that allows users to apply named variants to styles. This addresses issue #794 where users could create NamedVariant but had no way to activate them. Usage: ```dart final style = BoxStyler() .variant(small, BoxStyler().width(50)) .variant(large, BoxStyler().width(200)); Box(style: style.applyVariants([small])) ``` Closes #794
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an applyVariants() method to the Mix framework that allows developers to pre-apply named variants to styles, addressing issue #794 where users could define named variants but had no API to activate them.
Key Changes:
- Adds
applyVariants()method toVariantStyleMixinfor pre-applying named variants - Creates internal
AppliedVariantsStylewrapper class that stores and applies variants during resolution - Includes comprehensive test coverage for single/multiple variants, merging, and widget integration
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/mix/lib/src/style/mixins/variant_style_mixin.dart |
Adds the applyVariants() method with documentation and example usage |
packages/mix/lib/src/core/internal/applied_variants_style.dart |
Implements internal wrapper class that carries pre-applied variants and combines them with runtime variants |
packages/mix/test/src/style/mixins/variant_style_mixin_test.dart |
Adds comprehensive test suite covering single/multiple variants, merging, and widget tree integration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
applyVariants()method toVariantStyleMixinfor applying named variants to stylesAppliedVariantsStylewrapper class to carry pre-applied variantsProblem
Users could create
NamedVariantand add them to styles via.variant(), but there was no API to activate them (issue #794).Solution
Adds a simple
applyVariants()method that returns a wrapped style which passes the specified variants tobuild()during resolution.Usage
Test plan
applyVariantscovering single/multiple variants, merging, and widget tree integrationCloses #794