Skip to content

Simplify type function #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikrsna-buf merged 1 commit into from
Jan 13, 2026
Merged

Simplify type function #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions packages/cel/src/std/cast.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import { create, fromJson, isMessage, toJson } from "@bufbuild/protobuf";
import { create, fromJson, toJson } from "@bufbuild/protobuf";
import {
DurationSchema,
timestampFromMs,
Expand All @@ -31,11 +31,9 @@ import {
TIMESTAMP as TIMESTAMP_TYPE,
DURATION as DURATION_TYPE,
celType,
objectType,
type CelType,
} from "../type.js";
import { celUint } from "../uint.js";
import { getMsgDesc } from "../eval.js";
import { parseDuration } from "../duration.js";

const encoder = new TextEncoder();
Expand Down Expand Up @@ -193,12 +191,7 @@ const durationFunc = celFunc(DURATION, [
]);

const typeFunc = celFunc(TYPE, [
celOverload([CelScalar.DYN], CelScalar.TYPE, (v) => {
if (isMessage(v)) {
return objectType(getMsgDesc(v.$typeName));
}
return celType(v);
}),
celOverload([CelScalar.DYN], CelScalar.TYPE, celType),
]);

const dynFunc = celFunc(DYN, [
Expand Down
Loading