fix: missing env variables for 2 apis #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems there was some missing tokens for some APIs introduced by PR#30. This commit makes sure the automatic workflow on the `main` branch gets fixed!
|
ℹ️ API content change detected: No structural change, nothing to display.
|
When triggering the Diff on Bump.sh we need to use the `pull_request_target` workflow event to be able to have the private token on forked PRs. It's safe to do so because the `pull_request_target` event uses the base branch code (not the unsafe PR code) to run the workflow (which prevents any malicious users to alter the currently defined .github/workflows/diff.yml workflow to try to read the private token)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there was some missing tokens for some APIs introduced by
PR #30
This commit makes sure the automatic workflow on the
mainbranchgets fixed!