Skip to content

filippos/hw4-feedback #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flymperopoulos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

filippos/hw4-feedback #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cats/routes/catApp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ catapp.remove = function(req, res) {
if (err) {
res.status(500).send("Something broke!");
} else {
// Ooops be careful here - what happens when there are no cats and you try to remove one? Handle that null exception
// There is no property of name to cats.
var oldcat = cats.name;
var oldage = cats.age
res.render("remove", {"cats": [
Expand Down Expand Up @@ -107,6 +109,10 @@ catapp.sortedb = function(req, res) {
cat.find({ 'color': 'blue'}, 'name age color', callback(req, res))

}

// There is a repetition of the methods below that can be avoided. Instead of sorting
// for each seperate color you can parametarize the input path and handle that in your API (look for mongoose req.params)

//sorts for blue and bart named cats
catapp.sortedbb = function(req, res) {
var callback = function(req, res){
Expand Down