Homework 6 and 7 feedback #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Gabe,
Comments throughout your files -- you asked for advice about reorganizing your getUsers function, so I refactored the way I would have done it (see my feedback branch for a clean copy, without all of the diff craziness going on in the pr).
If you revisit Twoter to refactor & clean up and you'd like feedback/help, feel free to let us know!
In general, I think you have room to grow with regard to code cleanliness/maintainability (true for pretty much everyone, I think! I'm absolutely still working on it too). I get that this app was hard and your focus was on getting to work, but now that you're not seeing the material for the first time, you can spend more energy making sure your code spacing/indentation/curly-bracketing makes the code make sense, your function names explain the functions, there aren't any debugging mechanisms (console.logs, comments) hanging around (as interesting as it is to observe people's debugging processes, that doesn't belong in "production"), etc. I like to think of writing code kind of like I think about design -- your "users" are the people who work with you, review you, and build off of what you do as a developer, and you'll serve them well if you think about what they need and value in a codebase.
Remember not to merge these pull requests -- take a look at the feedback, feel free to comment if you'd like to discuss anything, and then close the PR.