Skip to content

Conversation

@rvanderheyde
Copy link
Collaborator

Hey Gabe,
Nice job setting up your test suite. However, I did see some things with your tests that you should be aware of. Firstly, while reusing code is good, generally you want it to actually work with the app you have. Your tests/server/models folder still contained tests for the Cat app and did not contain tests for the burger app. Also your package.json says its author is Evan Dorskey, which I am guessing happened because you forgot to remove the line when you copied it in from the sample app. Secondly, server side tests should do more than check if the status of a route is 200 (actually that applies to all tests). While that is something to test, you should also test that the data the route serves is in the proper format, actually has data, and is what you expect it to be. Finally, for client side testing you should be testing code you wrote for the client. This means testing that event handlers do the proper thing, that functions are outputting the proper values, etc. But all of those tests should be focused on functions written in your public/javascripts folder. Unfortunately, because you neither wrote any novel tests for the server, nor tested your database, I cannot give you credit for the assignment based off of what was submitted. If you have any questions or comments about this, email, slack or find me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants