Skip to content

Add EINVAL to TCGETS2/TCSETS2 fallback triggers #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NiltonVolpato wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −2
Open

Add EINVAL to TCGETS2/TCSETS2 fallback triggers #1573

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00258fc
Add EINVAL error handling for tcgetattr fallback
NiltonVolpato Jan 20, 2026
396c493
use correct error name
NiltonVolpato Jan 20, 2026
7423974
do the same for TCSETS2
NiltonVolpato Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/backend/linux_raw/termios/syscalls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ pub(crate) fn tcgetattr(fd: BorrowedFd<'_>) -> io::Result<Termios> {
// `TCGETS2`, for example a seccomp environment or WSL that only
// knows about `TCGETS`. Fall back to the old `TCGETS`.
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
Err(io::Errno::NOTTY) | Err(io::Errno::ACCESS) => tcgetattr_fallback(fd),
Err(io::Errno::NOTTY) | Err(io::Errno::ACCESS) | Err(io::Errno::INVAL) => {
tcgetattr_fallback(fd)
}

Err(err) => Err(err),
}
Expand Down Expand Up @@ -148,7 +150,7 @@ pub(crate) fn tcsetattr(
// Similar to `tcgetattr_fallback`, `NOTTY` or `ACCESS` might mean
// the OS doesn't support `TCSETS2`. Fall back to the old `TCSETS`.
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
Err(io::Errno::NOTTY) | Err(io::Errno::ACCESS) => {
Err(io::Errno::NOTTY) | Err(io::Errno::ACCESS) | Err(io::Errno::INVAL) => {
tcsetattr_fallback(fd, optional_actions, termios)
}

Expand Down
Loading