Follow up on wasm-tools #2421: New arena_id, rename of fixed length lists #187
+76
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpetig
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should wait for the upcoming wasm-tools 0.245 release (in the next days?), I try to prepare the downstream crates in advance for the incompatible renaming.
See bytecodealliance/wasm-tools#2421 for the renaming details (I was consistently using a different name than the one standardize for the component model and decided to change it better now or never).
The arena change is unfortunate and mandates changing a lot of crates at once. So, this is needed for any future wit-bindgen update.