Fix Edge browser detection causing proxy.set to fail

[jimchan3301]

Root Cause
The detection logic checked browser.proxy first, which exists in Edge but has Firefox-specific API behavior differences.

Solution
Detect Firefox using browser.runtime.getBrowserInfo(), a Firefox-specific API that doesn't exist in Chrome/Edge. This ensures Edge correctly uses the Chrome adapter.

[gemini-code-assist]

Summary of Changes

Hello @jimchan3301, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug where the Edge browser was misidentified as Firefox, leading to incorrect proxy configuration. The fix involves refining the browser detection mechanism to accurately distinguish Firefox from other Chromium-based browsers, thereby ensuring proper adapter selection and functionality for Edge users.

Highlights

• Root Cause Identified: The previous browser detection logic incorrectly identified Edge as Firefox because both browsers expose browser.proxy. This led to Edge attempting to use Firefox-specific proxy APIs, causing proxy.set to fail.
• Improved Firefox Detection: Firefox is now specifically detected using browser.runtime.getBrowserInfo(), an API unique to Firefox. This ensures that Edge correctly falls back to using the Chrome adapter, resolving the proxy configuration issue.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug in browser detection where Edge was being misidentified as Firefox. The previous check for browser.proxy was too generic. The new approach, checking for the Firefox-specific API browser.runtime.getBrowserInfo, is a much more reliable way to detect Firefox and ensures that Chromium-based browsers like Edge correctly fall back to using the Chrome adapter. The change is well-implemented and robust.

[SYM01]

Thank you @jimchan3301!

The change is merged into develop instead. Will try to release a new version ASAP, after doing some tests.