Implement negatively signed numbers #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Obviously the changes in commit ee2a4ae should be ignored. Test cases maybe should be increased to check for strings such as |
bzick
reviewed
Dec 1, 2025
go.mod
Outdated
| @@ -1,4 +1,4 @@ | |||
| module github.com/bzick/tokenizer | |||
| module github.com/kettek/tokenizer | |||
Owner
There was a problem hiding this comment.
can you change back to github.com/bzick/tokenizer?
bzick
reviewed
Dec 10, 2025
| } else { | ||
| break | ||
| } | ||
| } else if !hasExp && p.curr == '-' { // Allow starting numbers from a negative sign. |
Owner
There was a problem hiding this comment.
I analyzed this and realized it breaks backward compatibility. Let's make it a separate setting, something like "negative number parsing" settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation, having negative numbers, such as "-9" or "-9.99" will not be parsed as numbers but rather as keywords. This adjustments properly sets the start of number parsing to include the sign.