Add serial-port adapter, guard open/close with lock and disposal, and add tests #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
System.IO.Ports.SerialPortand enable unit testing of open/close behavior.Description
ISerialPortAdapterandSerialPortAdapterinsrc/Drivers/Transport/SerialPortAdapter.csto wrapSerialPortfor testability.SerialPortTransportto depend onISerialPortAdapter, add aSemaphoreSlim_connectionLock,_disposedchecks,ThrowIfDisposed()andCreateConfiguredPort()factory method, and ensure event unsubscription and buffer discard on dispose.Task.Runwrappers around open/close with proper async locking and disposal guards inConnectAsync/DisconnectAsyncand add safeDisposelogic.tests/Elatec.NET.Tests/SerialPortTransportTests.cswith aFakeSerialPortAdapterto validate open-once behavior, disconnect buffer discard, dispose closing, and thrown exceptions when using after dispose.Testing
dotnet test tests/Elatec.NET.Tests/Elatec.NET.Tests.csprojto execute the test suite.Passed! - Failed: 0, Passed: 21, Skipped: 0, Total: 21.ConnectAsync,DisconnectAsync,Dispose, and behavior when callingConnectAsyncafter disposal.Codex Task