Fix DESFire access rights packing order #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ToAccessRightsWord()andFromAccessRightsWord(ushort)onDESFireFileAccessRightsto pack/unpack using the datasheet nibble order.TWN4ReaderDevice.MifareDesfire.cswith the new helper methods (used for create/change/unpack of file access rights).tests/Elatec.NET.Tests/AccessRightsTests.csto assert correct pack/unpack behavior.ReadKeyNo,WriteKeyNo,ReadWriteKeyNo,ChangeKeyNo) unchanged for minimal surface-area impact, but behavior of packing is now spec-compliant.Testing
dotnet test tests/Elatec.NET.Tests/Elatec.NET.Tests.csprojand the test run completed successfully.Passed! - Failed: 0, Passed: 23, Skipped: 0, Total: 23.ToAccessRightsWordandFromAccessRightsWordpacking/unpacking behavior.Codex Task