-
Notifications
You must be signed in to change notification settings - Fork 1
Adiciona funções de utilidades do google sheets #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
rebecacalazans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comentários mais gerais:
- Troca o nome do PR pra descrever as mudanças. "Adding functions to manipulate google sheets" ou alguma coisa assim
- É bom você dar um merge da main na sua branch, pra pegar as mudanças novas
65a3926 to
3fe937f
Compare
…t_Upsolving into Func_GoogleSheets_Api
google_sheets_utilities.py
Outdated
| return request_body | ||
|
|
||
|
|
||
| def request_merge_rows(sheet_id, start_row, start_column, end_row, end_column): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essa função é exatamente igual a função de cima tirando 1 linha. Faz uma função pra resolver os 2 passando 1 parâmetro diferente pra resolver a diferença. Já vai ter muita linha, não aumente mais ainda.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cara, acho q assim fica mais facil de entender colocar um parametro e explicar dentro da funcao pode ficar bem confuso, acho melhor deixar assim. Caso vc realmente ache q eu deva colocar tudo junto, como sugere q eu faca?
Mas sinceramente acho q fica muito mais simples mudar por questao de entendimento
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| def merge_columns_request(tab_id, start_row, start_column, end_row, end_column): | ||
| ''' Pega o ID da tabela e o range de aplicacao da funcao | ||
| Retorna o request que junta as linhas num grid com o canto superior esquerdo em | ||
| (start_row, start_column) e canto inferior direito em (end_row-1, end_column-1)''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Qual o formato que ele pega a coluna?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ele junta as linhas das colunas do grid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ta mal explicado?
No description provided.