Fix failing CI due to conflict with nikic/php-parser #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereuromark
force-pushed
the
fix-php-parser-conflict
branch
from
29d89ad to
a4cb1fd
Compare
rector/rector bundles its own nikic/php-parser, and when PHPUnit runs with code coverage enabled, php-code-coverage also loads php-parser. This causes a class declaration collision: Cannot declare class PhpParser\Node\Scalar\InterpolatedString, because the name is already in use This is a known rector issue with no clean fix: rectorphp/rector#6958 Since this is a rector extension tool, code coverage isn't critical. Disabling it avoids the autoloader conflict entirely. Fixes CI failure: https://github.com/cakephp/upgrade/actions/runs/19643729518 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
dereuromark
force-pushed
the
fix-php-parser-conflict
branch
from
a4cb1fd to
2030502
Compare
dereuromark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nikic/php-parserto the conflict section in composer.jsonThis fixes the CI failure where
phpunit/php-code-coverage(a transitive dev dependency) pulls innikic/php-parser ^5.6.1, which conflicts with rector's bundled/scoped version causing:The
prefer-lowestjob passes because it gets older versions of php-code-coverage that don't require php-parser directly.Related: rectorphp/rector#6958
//EDIT:
Updated the PR to disable code coverage in CI instead - that's the actual fix since the conflict happens when php-code-coverage loads php-parser.