Skip to content

Conversation

@petebachant
Copy link
Member

TODO

  • Look up the correct way to do this. This feels a little hacky.
  • Make font sizes a little smaller across the board.

@petebachant
Copy link
Member Author

Current look on this branch:

image

@petebachant petebachant changed the title Make theme a little darker Make theme a little less blue Jan 27, 2026
@petebachant petebachant requested a review from Copilot January 27, 2026 19:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Chakra UI theme to make the dark mode palette less blue and closer to a GitHub-like dark scheme, and adds more explicit theming for several components.

Changes:

  • Tweaks the ui.dark and ui.darkSlate color values to new, less-blue hex values.
  • Introduces semantic color tokens for body background, text, borders, and placeholders, and adds a global body style that sets the background based on colorMode.
  • Adds component-level theming for Modal, Card, Menu, and Popover to use custom dark/light backgrounds and border colors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 28 to 31
"chakra-body-bg": {
_light: "white",
_dark: "#0d1117",
},
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You define semantic color tokens for "chakra-body-bg" here, but the global styles below set body.bg directly to ui.dark or white instead of using this token. That means the body background will not actually follow the semantic token value and you now have two separate sources of truth to keep in sync. To improve maintainability, consider wiring the global body background to this semantic token (or removing the token if it's intentionally unused).

Copilot uses AI. Check for mistakes.
Comment on lines +100 to +104
Modal: {
baseStyle: (props: any) => ({
dialog: {
bg: props.colorMode === "dark" ? "#161b22" : "white",
},
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new Modal, Card, Menu, and Popover baseStyle definitions all hardcode the same dark background color ("#161b22") in multiple places instead of reusing an existing theme token like ui.dark or a semantic token. This duplication makes it harder to tweak the dark theme later and increases the chance that one component diverges from the others. It would be more maintainable to centralize this color in the theme (for example via an existing color token) and reference that token from each component style.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants