fix(network-activity-plugin): getFormDataEntries(body).reduce is not … #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crockalet is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
V3RON
approved these changes
Jan 26, 2026
Contributor
V3RON
left a comment
V3RON
left a comment
There was a problem hiding this comment.
Thanks for fixing it!
I'm going to bring it into main soon.
Comment on lines
+50
to
+52
| const entriesArray = ( | ||
| Array.isArray(entries) ? entries : Array.from(entries || []) | ||
| ) as Array<[string, unknown]>; |
Contributor
There was a problem hiding this comment.
No need to check whether entries is an array. Array.from will simply return a copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a function
Description
Converted FormData entries iterator to an array before reduce to avoid reduce is not a function and keep request body parsing stable.
Related Issue
#170
Context
getFormDataEntries() can return an iterator in some environments, which does not implement reduce. Converting to an array fixes the runtime error while preserving existing behavior.
Testing
--