-
Notifications
You must be signed in to change notification settings - Fork 50
Scenario picker fixes #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How can a legacy scenario have an unrecognized special node? |
|
It happens here: https://github.com/calref/cboe/blob/master/src/scenario/special.cpp#L525 I didn't check which scenarios were the ones that caused it. |
|
Would that be difficult to check? |
|
Not too difficult, no. When I say 'the whole scenario archive', I'm referring to this one arranged by The Lurker via Kelandon's archive and other sources. I've copied it to a repository here in which I ran a script to extract every zip file, because each scenario was in a separate one. (I'm experimenting with the possibility of shipping Itch Edition with the complete archive, which would obviate the need for an online scenario browser unless/until we start seeing new scenario releases again.) Printing the identity of the scenarios that contain unrecognized nodes, it turns out there's only one. Its name field is blank but there's the filename and node numbers. EDIT: Wait a sec, I've found more, but I think they only show the error when you enter the scenario (probably because the unrecognized nodes are on a town or outdoor node, not scenario node?) |
Did you extract the zips on a Mac? Did you manually convert all the .meg files to data-fork files?
Okay, comparing those numbers to here doesn't reveal any matches, so I think there's a good chance that this just comes from garbage data in the file. Not sure how that could've happened though… |
Yes.
No, should I? How do I do that? |
I think it would be a good idea, because it enables the files to be stored on an NTFS filesystem.
I found this answer on StackOverflow. It's old, so I don't know if it'll still work on MacOS 15. (I also don't know what happens to resource forks when stored on an APFS drive…) |
|
To be honest I don't even know what a resource file vs resource fork vs data fork is. This stuff is from a few years before the first time I had my own computer. Most of my searches are not turning up anything on MEG as a standard MacOS file type, they're talking about modern formats for unrelated projects. That StackOverflow gives this one-liner, but it's unclear what to replace with what when invoking it...
|
|
Something like this, maybe? |
|
Closing in favor of #788 |
I threw the whole scenario archive in my scenarios folder and found some bugs.
This fixes them and adds a '#' button which pages the picker to the first page of custom scenarios.