Trying to fix the 404 issue #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yeah, we currently have no way to test changes in staging 😅 I think it does need an escape, since it's within a |
mxbi
requested changes
Jan 29, 2024
Member
mxbi
left a comment
mxbi
left a comment
There was a problem hiding this comment.
" needs escapes unfortunately (pretty sure)
Member
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes #6 but will need testing because I wasn't sure if the escape character \ is needed (e.g.
<a href="mailto"> vs. <a href\="mailto">Also not sure if just deleting a menu item is that simple but I have no way to test it lmao - some help from you @mxbi and I will setup a test server for myself