Skip to content

Conversation

@onitake
Copy link
Contributor

@onitake onitake commented May 28, 2020

Since 19.4, cloud-init supports a more reliable approach to obtain the CloudStack user-data server address than DHCP: Via the well-known data-server. hostname.

I think this deserves to be documented.

Commit when the feature was added: 9662a87

I also submitted a documentation PR to the CloudStack project, so they are in line: apache/cloudstack-documentation#132

@onitake
Copy link
Contributor Author

onitake commented May 28, 2020

I'm sorry, I thought I had already signed the CLA previously, but that wasn't the case.
I signed it now, please verify again.

@OddBloke OddBloke self-assigned this Jun 8, 2020
Copy link
Collaborator

@OddBloke OddBloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, and apologies for the time it's taken to get to this review! This looks good, and brings our documentation in line with what our code does, which is great! I have one inline suggested addition, which rounds out the full algorithm described.

Other than that: I can see your CLA signature, so all you need to do is add your GH username to tools/.github-cla-signers (in its alphabetically appropriate location) and that check will start passing.

Thanks again!

@onitake
Copy link
Contributor Author

onitake commented Jun 9, 2020

I added myself to the CLA list on this branch here, hope that's ok. I can create a separate PR if you prefer.

Copy link
Collaborator

@OddBloke OddBloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants