Skip to content

Conversation

@cappallo
Copy link
Owner

Summary

  • add SupervisorNoHandler and RootSupervisor actors to the supervision example to exercise multi-level failure bubbling
  • add a regression test that ensures ChildFailed notifications reach ancestors when intermediate supervisors omit a handler
  • refresh STATUS.md with the new example coverage and updated totals

Testing

  • npm run build --silent
  • npm test --silent

Codex Task

Copilot AI review requested due to automatic review settings November 11, 2025 17:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the actor supervision example by adding multi-level supervision hierarchy testing. The changes add two new actor types (SupervisorNoHandler and RootSupervisor) and a regression test to verify that ChildFailed notifications correctly propagate through supervisors that lack failure handlers.

Key Changes

  • Added SupervisorNoHandler actor: an intermediate supervisor that forwards messages but lacks a ChildFailed handler
  • Added RootSupervisor actor: a top-level supervisor with failure tracking that spawns SupervisorNoHandler
  • Added failure_propagates_without_intermediate_handler test: validates failure propagation across multiple supervision levels
  • Updated STATUS.md with new test coverage documentation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
examples/actor_supervision.lx Adds two new supervisor actors and a test to verify multi-level failure propagation when intermediate supervisors omit ChildFailed handlers
STATUS.md Updates documentation with the new test coverage and incorrectly increments example file count

## 🎯 Working Examples

The implementation successfully runs 36 example files (27 runnable + 9 error test cases) including:
The implementation successfully runs 37 example files (28 runnable + 9 error test cases) including:
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example file count appears to be incorrect. This PR adds new actors and tests to the existing examples/actor_supervision.lx file but doesn't add any new example files. The count should remain at 36 example files (27 runnable + 9 error test cases), not increase to 37 (28 runnable + 9 error test cases).

Suggested change
The implementation successfully runs 37 example files (28 runnable + 9 error test cases) including:
The implementation successfully runs 36 example files (27 runnable + 9 error test cases) including:

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants