Skip to content

Conversation

@gsalinaslopez
Copy link
Collaborator

@gsalinaslopez gsalinaslopez commented Dec 2, 2025

Changes

  • NowPlaying screen refactoring to pass server ip with @Assisted hilt injection from NavHost
  • Move snapclient service and snapcast control initialization from tuneIn into nowPlaying viewModels

Passing values to a viewModel using navigation reference: https://github.com/android/nav3-recipes/tree/main#passing-navigation-arguments-to-viewmodels

Copy link
Collaborator

@garpernica garpernica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement switching to a data class for NowPlaying nav key enables parameterized routing—much better than hardcoded values.
The Hilt-assisted ViewModel creation is spot-on.
Consider adding a comment above the nav entry explaining the serverIp extraction for future maintainers
It's good you removed the empty onUnbind —dead code gone.

@gsalinaslopez gsalinaslopez merged commit 01bd2b8 into develop Dec 5, 2025
3 checks passed
@gsalinaslopez gsalinaslopez deleted the refactor/nowPlaying-tuneIn-viewModel branch December 5, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants