Skip to content

Allow deleting gts files that have a module error #3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jurgenwerk wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −0
Open

Allow deleting gts files that have a module error #3886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/host/app/components/operator-mode/detail-panel.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ export default class DetailPanel extends Component<Signature> {
private get showDetailsPanel() {
return (
this.args.cardError ||
this.args.moduleAnalysis.moduleError ||
(!this.isModule && !isCardDocumentString(this.args.readyFile.content))
);
}
Expand Down
24 changes: 24 additions & 0 deletions packages/host/tests/acceptance/code-submode/inspector-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@ const employeeCardSource = `
}
`;

const erroringModuleSource = `throw new Error('boom');`;

const inThisFileSource = `
import {
contains,
Expand Down Expand Up @@ -468,6 +470,7 @@ module('Acceptance | code submode | inspector tests', function (hooks) {
're-export.gts': reExportSource,
'local-inherit.gts': localInheritSource,
'command-module.gts': commandModuleSource,
'erroring-module.gts': erroringModuleSource,
'empty-file.gts': '',
'person-entry.json': {
data: {
Expand Down Expand Up @@ -2161,6 +2164,27 @@ export class ExportedCard extends ExportedCardParent {
assert.dom('[data-test-delete-module-button]').exists();
});

test('can delete an erroring module file', async function (assert) {
await visitOperatorMode({
stacks: [[]],
submode: 'code',
codePath: `${testRealmURL}erroring-module.gts`,
});

await waitFor('[data-test-syntax-error]');
await waitFor('[data-test-action-button="Delete"]');

await click('[data-test-action-button="Delete"]');
await waitFor(
`[data-test-delete-modal="${testRealmURL}erroring-module.gts"]`,
);
await click('[data-test-confirm-delete-button]');
await waitFor('[data-test-empty-code-mode]');

let notFound = await adapter.openFile('erroring-module.gts');
assert.strictEqual(notFound, undefined, 'file ref does not exist');
});

module('when the user lacks write permissions', function (hooks) {
hooks.beforeEach(async function () {
setRealmPermissions({ [testRealmURL]: ['read'] });
Expand Down