Skip to content

Fixes .close() method #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
whazap wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes .close() method #264

whazap wants to merge 2 commits into from

Conversation

@whazap
Copy link
Contributor

@whazap whazap commented Dec 5, 2015

  • adds some (maybe ugly, apologizes!) test for it.

@hhsnopek
Copy link
Contributor

hhsnopek commented Feb 17, 2016

hey @whazap - would you be able to rebase master onto this? I'd like to merge this in before I cut a release tomorrow morning 😄

@whazap
Fixes the close() method
0a549ae
@whazap
Updates test for close() fix
1e358fc 
So the test eventually .. i mean .. actually .. works. ;-)

Related: carrot#253
@whazap
Copy link
Contributor Author

whazap commented Feb 17, 2016

sure! done! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whazap @hhsnopek