Skip to content

Conversation

@endersonmaia
Copy link
Contributor

@endersonmaia endersonmaia commented Dec 3, 2024

This pull request includes several changes to the @cartesi/cli package to expose a GraphQL endpoint and provide options to enable or disable it. The changes include updates to the CLI commands, Docker Compose configurations, and related services.

Major changes:

  • Expose GraphQL endpoint:

    • Added a major change entry in the .changeset/heavy-penguins-act.md file to document the exposure of the GraphQL endpoint.
  • CLI command updates:

    • Added a new option --disable-graphql to the registerRunCommand function in apps/cli/src/commands/run.ts to allow users to disable the local GraphQL service.
    • Updated the registerRunCommand function to include the docker-compose-graphql.yaml file if the GraphQL service is not disabled.
  • Docker Compose configuration:

    • Added a new docker-compose-graphql.yaml file in apps/cli/src/node to define the services required for the GraphQL endpoint, including database creation, migration, and the GraphQL service itself.

Minor changes:

  • Validator Docker Compose adjustments:
    • Removed the GraphQL-related configuration from the docker-compose-validator.yaml file to avoid conflicts and ensure proper setup. [1] [2]

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: b5e77f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/cli Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@endersonmaia endersonmaia requested a review from tuler December 3, 2024 17:07
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 30.9% 293 / 948
🔵 Statements 31% 298 / 961
🔵 Functions 34.22% 51 / 149
🔵 Branches 27.25% 121 / 444
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/cli/src/commands/run.ts 0% 0% 0% 0% 7-247
Generated in workflow #287 for commit b5e77f5 by the Vitest Coverage Report Action

@endersonmaia endersonmaia force-pushed the feature/add-hl-graphql-to-sdk branch from 94e65d3 to 45efe41 Compare December 5, 2024 13:34
@endersonmaia endersonmaia force-pushed the feature/add-graphql-service-to-cli branch from 2bf539a to 77e0506 Compare December 5, 2024 13:35
@tuler tuler force-pushed the feature/add-hl-graphql-to-sdk branch from 45efe41 to db74e30 Compare January 8, 2025 16:08
@tuler tuler force-pushed the feature/add-graphql-service-to-cli branch from 77e0506 to 81fcfc0 Compare January 8, 2025 16:57
@tuler tuler changed the title feat(cli): expose graphql endpoint Expose GraphQL endpoint in CLI Jan 8, 2025
@tuler
Copy link
Member

tuler commented Jan 8, 2025

Rebased

@tuler tuler force-pushed the feature/add-graphql-service-to-cli branch from 81fcfc0 to f6b328b Compare January 8, 2025 16:59
@endersonmaia endersonmaia force-pushed the feature/add-hl-graphql-to-sdk branch 3 times, most recently from d6c7bbb to 16b6bf3 Compare January 22, 2025 18:45
@endersonmaia endersonmaia force-pushed the feature/add-graphql-service-to-cli branch from f6b328b to d54ad41 Compare January 22, 2025 19:57
@endersonmaia endersonmaia requested a review from tuler January 22, 2025 20:06
Base automatically changed from feature/add-hl-graphql-to-sdk to prerelease/v2-alpha January 22, 2025 20:47
@endersonmaia endersonmaia force-pushed the feature/add-graphql-service-to-cli branch from d54ad41 to 78ff2de Compare January 22, 2025 20:58
@endersonmaia endersonmaia force-pushed the feature/add-graphql-service-to-cli branch from 78ff2de to d327086 Compare January 23, 2025 14:47
@endersonmaia endersonmaia force-pushed the feature/add-graphql-service-to-cli branch 2 times, most recently from ea5cd4e to 5d87693 Compare January 31, 2025 14:04
@endersonmaia endersonmaia changed the base branch from prerelease/v2-alpha to feature/cli-run-v2 February 26, 2025 19:12
@endersonmaia endersonmaia force-pushed the feature/add-graphql-service-to-cli branch from 5d87693 to 8b6b4df Compare February 26, 2025 19:55
@endersonmaia endersonmaia self-assigned this Feb 26, 2025
Copy link

@fabiooshiro fabiooshiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@endersonmaia endersonmaia force-pushed the feature/add-graphql-service-to-cli branch 2 times, most recently from d22590b to 492adba Compare February 27, 2025 14:02
@tuler tuler force-pushed the feature/cli-run-v2 branch from a7e55c5 to 7feeb21 Compare February 28, 2025 14:36
@endersonmaia endersonmaia force-pushed the feature/add-graphql-service-to-cli branch from 492adba to 635e44e Compare February 28, 2025 18:08
@tuler tuler force-pushed the feature/cli-run-v2 branch 2 times, most recently from 44df851 to 1297ea6 Compare March 5, 2025 22:17
@tuler
Copy link
Member

tuler commented Mar 6, 2025

This case be closed when we finalize PR #116, because it's handled there through --services graphql.
It can still be open, for reference, until we merge that other one.

@tuler tuler force-pushed the feature/cli-run-v2 branch 2 times, most recently from 39558cf to d496299 Compare March 6, 2025 18:31
@tuler tuler force-pushed the feature/cli-run-v2 branch 5 times, most recently from b999336 to 24ad87e Compare March 17, 2025 14:09
Base automatically changed from feature/cli-run-v2 to prerelease/v2-alpha March 17, 2025 14:23
@tuler
Copy link
Member

tuler commented Mar 17, 2025

I think this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants