refactor(cli): compose image definition in a single place #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 855012a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Coverage Report for ./apps/cli
File Coverage
|
||||||||||||||||||||||||||||||||||||||
endersonmaia
force-pushed
the
feature/single-place-image-definition
branch
from
a27b565 to
f350102
Compare
endersonmaia
force-pushed
the
feature/cli-run-v2
branch
from
b4e999f to
78b5056
Compare
endersonmaia
force-pushed
the
feature/single-place-image-definition
branch
from
f350102 to
2fc76ba
Compare
endersonmaia
force-pushed
the
feature/cli-run-v2
branch
from
78b5056 to
d2c37a4
Compare
endersonmaia
force-pushed
the
feature/single-place-image-definition
branch
from
2fc76ba to
a6a9af4
Compare
tuler
reviewed
Feb 25, 2025
Member
tuler
left a comment
tuler
left a comment
There was a problem hiding this comment.
This use of extends is quite unorthodox. I don't think I like it.
Contributor
Author
It's a new feature, and it makes our code more maintainable, IMO. When you use |
endersonmaia
force-pushed
the
feature/cli-run-v2
branch
2 times, most recently
from
a82afdd to
a7e55c5
Compare
tuler
force-pushed
the
feature/cli-run-v2
branch
5 times, most recently
from
39558cf to
d496299
Compare
tuler
force-pushed
the
feature/cli-run-v2
branch
2 times, most recently
from
b295744 to
48ddef2
Compare
Merged
tuler
force-pushed
the
feature/cli-run-v2
branch
2 times, most recently
from
caf7a2f to
c2a395d
Compare
Contributor
Author
|
Solved at #116 using environment variable replacement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
@cartesi/clipackage, focusing on centralizing the definition of Docker images and refactoring the Docker Compose files to use a base configuration. The most important changes are outlined below:Refactoring and Centralization:
cartesi/sdkandcartesi/rollups-nodeimages. (.changeset/selfish-dots-perform.md)Code Updates:
DEFAULT_SDKfromconfig.jsand used it in theRuncommand to set theCARTESI_SDK_IMAGEenvironment variable. (apps/cli/src/commands/run.ts) [1] [2]Docker Compose Refactoring:
docker-compose-anvil.yamlto extend fromdocker-compose-base.yamlforsdk_imageandrollups_node_imageservices. (apps/cli/src/node/docker-compose-anvil.yaml) [1] [2]docker-compose-base.yamlwith definitions forsdk_imageandrollups_node_imageservices. (apps/cli/src/node/docker-compose-base.yaml)docker-compose-bundler.yaml,docker-compose-database.yaml,docker-compose-espresso.yaml,docker-compose-paymaster.yaml,docker-compose-validator.yaml) to extend fromdocker-compose-base.yamlfor consistency. [1] [2] [3] [4] [5]