Skip to content

Conversation

@tuler
Copy link
Member

@tuler tuler commented Jul 18, 2025

This PR implements the following build improvements:

  • support for buildArgs
  • change from --append-entrypoint to "command"
  • add debug option to not remove intermediate files

it also have some unrelated simple fixes or style lint changes.

  • fix amount display in erc20 deposit
  • bump biome and fix some style errors

@tuler tuler requested a review from endersonmaia July 18, 2025 15:11
@socket-security
Copy link

socket-security bot commented Jul 18, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​biomejs/​biome@​1.9.4 ⏵ 2.1.2100 +710010099 +1100

View full report

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 27.24% 303 / 1112
🔵 Statements 27.11% 308 / 1136
🔵 Functions 26.98% 51 / 189
🔵 Branches 23.91% 121 / 506
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/cli/src/config.ts 90.85% 84.26% 96.77% 90.68% 66-67, 222, 230, 240, 260, 273, 283, 286, 296, 337, 348-352, 364
apps/cli/src/machine.ts 0% 0% 0% 0% 4-118
apps/cli/src/prompts.ts 0% 0% 0% 0% 30-293
apps/cli/src/wallet.ts 0% 0% 0% 0% 14-55
apps/cli/src/builder/directory.ts 100% 75% 100% 100%
apps/cli/src/builder/docker.ts 90.9% 75% 60% 95.23% 40, 43, 138-144
apps/cli/src/commands/build.ts 0% 0% 0% 0% 16-100
apps/cli/src/commands/deposit.ts 0% 100% 0% 0% 7-44
apps/cli/src/commands/logs.ts 0% 0% 0% 0% 5-48
apps/cli/src/commands/run.ts 0% 0% 0% 0% 25-317
apps/cli/src/commands/send.ts 0% 0% 0% 0% 16-159
apps/cli/src/commands/shell.ts 0% 0% 0% 0% 8-54
apps/cli/src/commands/deposit/erc20.ts 0% 0% 0% 0% 35-179
apps/cli/src/commands/deposit/erc721.ts 0% 0% 0% 0% 35-201
apps/cli/src/commands/deposit/ether.ts 0% 0% 0% 0% 11-81
apps/cli/src/exec/cartesi-machine.ts 75% 50% 50% 75% 14, 31-33
apps/cli/src/exec/rollups.ts 0% 0% 0% 0% 43-556
Generated in workflow #624 for commit c6c8705 by the Vitest Coverage Report Action

@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2025

🦋 Changeset detected

Latest commit: 020a2d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tuler tuler force-pushed the feature/build-improvements branch from 714f343 to dda7590 Compare July 18, 2025 17:35
Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuler tuler force-pushed the feature/build-improvements branch from 020a2d1 to c6c8705 Compare July 19, 2025 03:17
@tuler tuler merged commit bb82040 into prerelease/v2-alpha Jul 19, 2025
4 checks passed
@tuler tuler deleted the feature/build-improvements branch July 19, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants