Skip to content

Conversation

@tuler
Copy link
Member

@tuler tuler commented Jul 18, 2025

New config for cartesi.toml

  • use_docker_env: inject docker image ENV into cartesi-machine ENV (default: true)
  • use_docker_workdir: inject docker image WORKDIR into cartesi-machine WORKDIR (default: true)

@tuler tuler requested a review from endersonmaia July 18, 2025 21:29
@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2025

🦋 Changeset detected

Latest commit: a2f1448

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 24.74% 271 / 1095
🔵 Statements 24.66% 276 / 1119
🔵 Functions 25.26% 48 / 190
🔵 Branches 21.71% 109 / 502
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/cli/src/config.ts 90.85% 84.26% 96.77% 90.68% 66-67, 226, 234, 244, 264, 277, 287, 290, 300, 341, 352-356, 368
apps/cli/src/machine.ts 0% 0% 0% 0% 5-122
Generated in workflow #637 for commit a2f1448 by the Vitest Coverage Report Action

Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuler tuler force-pushed the feature/toml-snake-case branch from ffbefbe to 33bb766 Compare July 19, 2025 03:21
@tuler tuler force-pushed the feature/use-docker-machine branch from c1d7a30 to aeba159 Compare July 19, 2025 03:22
@tuler tuler force-pushed the feature/toml-snake-case branch from 33bb766 to e7cf8fb Compare July 19, 2025 04:30
@tuler tuler force-pushed the feature/use-docker-machine branch from aeba159 to 7fe089b Compare July 19, 2025 04:30
@tuler tuler force-pushed the feature/toml-snake-case branch from e7cf8fb to d2f2e84 Compare July 21, 2025 13:17
@tuler tuler force-pushed the feature/use-docker-machine branch from 7fe089b to 11a7966 Compare July 21, 2025 13:17
Base automatically changed from feature/toml-snake-case to prerelease/v2-alpha July 22, 2025 20:38
@tuler tuler force-pushed the feature/use-docker-machine branch from 11a7966 to a2f1448 Compare July 22, 2025 20:39
@tuler tuler merged commit a339107 into prerelease/v2-alpha Jul 22, 2025
4 checks passed
@tuler tuler deleted the feature/use-docker-machine branch July 22, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants