-
Notifications
You must be signed in to change notification settings - Fork 12
Possibility to use an override config file #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9a602ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage Report for ./apps/cli
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Using honeypot branch to test, I get the following error but it's not clear what is the problem: |
endersonmaia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
11a7966 to
a2f1448
Compare
26a32ad to
9a602ce
Compare
This PR allows the use of multiple config files for build, with an override strategy.
This enables something like:
Where
cartesi.tomlcontains common configuration, andcartesi.mainnet.tomlonly contains values that should complement or override values incartesi.toml. This helps to reduce code duplication, improving maintenance, like in this commit.This PR also removes 3 properties from the config that I think could lead to confusion:
interactive,storeandfinalHash